Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix conflicting nodeclaim.garbagecollcation controller name #6996

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Fix conflicting nodeclaim.garbagecollection controller name to now be instance.garbagecollection

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 12, 2024 19:08
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 12, 2024 19:08
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 520dcec
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66e33cc7846de20008853cf1

jigisha620
jigisha620 previously approved these changes Sep 12, 2024
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10837219217

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.04%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/garbagecollection/controller.go 1 2 50.0%
Totals Coverage Status
Change from base Build 10837033964: 0.02%
Covered Lines: 5513
Relevant Lines: 6639

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit ecd431e into aws:main Sep 12, 2024
16 checks passed
@jonathan-innis jonathan-innis deleted the fix-conflicting-controller-name branch September 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants