Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: monitor leaked node lease using tests #6829

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Added test that would run after each test to ensure that we are not leaking any leases.

How was this change tested?
Ran test on my local cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner August 21, 2024 20:59
@jigisha620 jigisha620 requested a review from njtran August 21, 2024 20:59
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 5897169
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c65a856b840200082d78ee

@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 10497687362

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.324%

Totals Coverage Status
Change from base Build 10497137757: 0.01%
Covered Lines: 5939
Relevant Lines: 7487

💛 - Coveralls

test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
test/pkg/environment/common/expectations.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 1460366 into aws:main Aug 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants