Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix cloud formation resources #6774

Merged
merged 1 commit into from
Aug 15, 2024
Merged

docs: fix cloud formation resources #6774

merged 1 commit into from
Aug 15, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Aug 15, 2024

Fixes #N/A

Description
We orchestrate releases by pushing tags, which triggers a github action to create a PR to modify the docs. This means that referencing the raw github files at the tagged commit for the docs folder will have missed any docs updates added during the release automation. This updates it to use preview so that the cloud formation references what was staged for each release, which was eventually brought in through release automation.

How was this change tested?
Looking at the links manually, seeing CFN updates for v1 that were expected only in the preview link

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner August 15, 2024 18:19
@njtran njtran requested a review from tzneal August 15, 2024 18:19
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 8f47caa
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66be46ac03ebfd000843ac95
😎 Deploy Preview https://deploy-preview-6774--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10408510517

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.264%

Totals Coverage Status
Change from base Build 10407691741: 0.0%
Covered Lines: 5921
Relevant Lines: 7470

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 3e6cbc5 into aws:main Aug 15, 2024
16 checks passed
@njtran njtran deleted the cfndocs branch August 15, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants