Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gomod and add cloudprovider method #6773

Merged
merged 1 commit into from
Aug 15, 2024
Merged

chore: update gomod and add cloudprovider method #6773

merged 1 commit into from
Aug 15, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Aug 15, 2024

Fixes #N/A

Description
Updates to bring in kubernetes-sigs/karpenter#1574

How was this change tested?
here

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner August 15, 2024 17:09
@njtran njtran requested a review from engedaam August 15, 2024 17:09
@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1244003
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66be363403ebfd0008403fec

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10407589255

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 79.264%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 0 3 0.0%
pkg/fake/cloudprovider.go 0 3 0.0%
Totals Coverage Status
Change from base Build 10407500565: -0.06%
Covered Lines: 5921
Relevant Lines: 7470
💛 - Coveralls

engedaam
engedaam approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) August 15, 2024 17:14
@njtran njtran merged commit 67273e2 into aws:main Aug 15, 2024
16 checks passed
@njtran njtran deleted the disruptionReasons branch August 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njtran @coveralls @engedaam