Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: invalid Getting Started NodePool yaml #6769

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

Anorlondo448
Copy link
Contributor

@Anorlondo448 Anorlondo448 commented Aug 15, 2024

Fixes #N/A

Description
Nodepool's yaml in Getting Started doesn't have a v1 spec

How was this change tested?
Deployed NodePool.yaml and checked

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Anorlondo448 Anorlondo448 requested a review from a team as a code owner August 15, 2024 12:29
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit dfd8899
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66be3c38667705000809178f

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) August 15, 2024 20:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10407943678

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.277%

Totals Coverage Status
Change from base Build 10407691741: 0.01%
Covered Lines: 5922
Relevant Lines: 7470

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 75a7aa5 into aws:main Aug 15, 2024
16 checks passed
@Anorlondo448 Anorlondo448 deleted the invalid_nodepool branch August 15, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants