docs: Update Terraform getting started guide to include recent changes #2913
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -33,10 +33,10 @@ Install these tools before proceeding: | |||
| 1. [AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html) | |||
| 2. `kubectl` - [the Kubernetes CLI](https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/) | |||
| 3. `terraform` - [infrastructure-as-code tool made by HashiCorp](https://learn.hashicorp.com/tutorials/terraform/install-cli) | |||
| 4. `helm` - [the package manager for Kubernetes](https://helm.sh/docs/intro/install/) | |||
There was a problem hiding this comment.
Not required since this is handled through Terraform via Helm's SDK
|
|
||
| Login to the AWS CLI with a user that has sufficient privileges to create a | ||
| cluster. | ||
| [Configure the AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-quickstart.html) |
There was a problem hiding this comment.
Copied from eksctl getting started guide
| } | ||
| name = "karpenter" | ||
| repository = "oci://public.ecr.aws/karpenter" | ||
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name |
There was a problem hiding this comment.
uses data source to pull creds to ensure chart can be pulled from ECR
|
|
||
| set { | ||
| name = "settings.aws.clusterName" | ||
| value = module.eks.cluster_id |
There was a problem hiding this comment.
we will want to rely on cluster_name and not cluster_id since there is a new distinction coming with the support for EKS local clusters on outposts hashicorp/terraform-provider-aws#27560
Nothing required here other than where most instances of cluster_id are used, we should use cluster_name
| ] | ||
| } | ||
|
|
||
| resource "kubectl_manifest" "karpenter_node_template" { |
There was a problem hiding this comment.
tags were removed from node group to de-emphasize the launch template usage of Karpenter and switch to the node template which has been added here
|
this looks great |
Fixes #
Description
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.