Skip to content

fix(jsii-reflect): statically guarantee JsiiFeature subset #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(jsii-reflect): statically guarantee JsiiFeature subset #4956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/jsii-reflect/lib/type-system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ export const JSII_REFLECT_SUPPORTED_ASSEMBLY_FEATURES: JsiiFeature[] = [
'class-covariant-overrides',
];

/**
* All supported features as a type
*/
export type JsiiReflectSupportedAssemblyFeatures =
(typeof JSII_REFLECT_SUPPORTED_ASSEMBLY_FEATURES)[number];

export class TypeSystem {
/**
* The "root" assemblies (ones that loaded explicitly via a "load" call).
Expand Down Expand Up @@ -368,7 +374,7 @@ export class TypeSystem {
private loadAssembly(
file: string,
validate = true,
supportedFeatures?: JsiiFeature[],
supportedFeatures?: JsiiReflectSupportedAssemblyFeatures[],
) {
validateFeatureSubset(supportedFeatures);
const contents = loadAssemblyFromFile(file, validate, supportedFeatures);
Expand Down
Loading