Skip to content

chore: make error message about statics more descriptive #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rix0rrr merged 3 commits into from
Oct 9, 2018
Merged

chore: make error message about statics more descriptive #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1c76a9
chore: make error message about statics more descriptive
Oct 2, 2018
49c6679
Update error message to be a bit more correct and typescripty
rix0rrr Oct 2, 2018
7e7362e
Update expected errors
Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jsii/lib/validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function _defaultValidations(): ValidationFunction[] {
if (member.static && (member as spec.Property).const) { continue; }
if (member.name && member.name !== Case.camel(member.name)) {
diagnostic(ts.DiagnosticCategory.Error,
`Method and property names must use camelCase: ${member.name}`);
`Method and non-static non-readonly property names must use camelCase: ${member.name}`);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.method-name.1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: METHOD
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: METHOD

export class MyClass {
public METHOD() {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.method-name.2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: hello_world
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: hello_world

export class MyClass {
public hello_world() {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.property-name.1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: PROP
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: PROP

export class MyClass {
public PROP?: number;
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.property-name.2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: my_Prop
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: my_Prop

export class MyClass {
public my_Prop?: number;
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.static-method-name.1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: MethodIsNotCamelCase
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: MethodIsNotCamelCase

export class MyClass {
MethodIsNotCamelCase() {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.static-method-name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: METHOD
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: METHOD

export class MyClass {
METHOD() {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.static-prop-name.1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: Prop
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: Prop

export class MyClass {
static get Prop() {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii/test/negatives/neg.static-prop-name.2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
///!MATCH_ERROR: Method and property names must use camelCase: PROP
///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: PROP

export class MyClass {
static get PROP() {
Expand Down