fix(stability): enable Health_Check for the /api/v1/health container check - #168
Merged
Merged
Conversation
TheanLim
force-pushed
the
fix/stability-healthcheck-enable-hc
branch
from
July 15, 2026 23:41
7ef561c to
e3bc72d
Compare
TheanLim
marked this pull request as ready for review
July 15, 2026 23:42
danehlim
approved these changes
Jul 16, 2026
singholt
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable
Health_Check Onin the[SERVICE]block of the two stability templates used byecs-firelens-stability-tests, keeping the/api/v1/healthcontainer health check from #166 unchanged:apps/firelens-stability/templates/golden-path-mountebank-fargate-v01-11-2023/fluent-bit.confapps/firelens-stability/templates/s3-fargate-v04-05-2023/fluent-bit.confWhy
The health check added in #166 uses
curl -f http://127.0.0.1:2020/api/v1/health, but the stability configs setHTTP_Server OnwithoutHealth_Check On./api/v1/healthis only registered as a real endpoint when theHealth_Checkfeature is enabled. Without it:/route became exact-match after the upstreamHTTP server rewrite, fluent/fluent-bit#11538), so every task reports UNHEALTHY.
Testing
/api/v1/health->200 okon both FLB 1.9.10 and 5.0.9 withHealth_Check On.apps/firelens-stability) using upstream 5.0.9 and all tasks reported healthy.