Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloud-provider-aws GIT_TAG #2267

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Update cloud-provider-aws GIT_TAG #2267

merged 2 commits into from
Aug 16, 2023

Conversation

adityavenneti
Copy link
Member

Issue #2265

Description of changes:
Updating cloud-provider-aws GIT_TAG in preparation for a new release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from adityavenneti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added v1.23 v1.24 project Adds, Removes, or updates GIT_TAG in projects folder v1.25 v1.26 v1.27 v1.28 labels Aug 16, 2023
markapruett
markapruett reviewed Aug 16, 2023
View reviewed changes
projects/kubernetes/cloud-provider-aws/1-23/GIT_TAG
@@ -1 +1 @@
v1.23.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we really update that many patch versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, or does it jsut track the k8s version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal source of truth is used to determine which patch version to upgrade to for this component.

@zafs23
Copy link
Contributor

zafs23 commented Aug 16, 2023

/lgtm

@adityavenneti adityavenneti merged commit 44fb055 into aws:main Aug 16, 2023
1 check passed
danbudris pushed a commit to danbudris/eks-distro that referenced this pull request Sep 25, 2023
@adityavenneti @danbudris
Update cloud-provider-aws GIT_TAG (aws#2267)
ab35c7f 
* Update cloud-provider-aws GIT_TAG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markapruett markapruett markapruett left review comments

Assignees

@zafs23 zafs23

Labels
lgtm project Adds, Removes, or updates GIT_TAG in projects folder size/M v1.23 v1.24 v1.25 v1.26 v1.27 v1.28
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityavenneti @eks-distro-bot @zafs23 @markapruett