test: Fix git related error in 'build-rpm', add rocky9 #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a git not found warning/error and add rocky9
to the circleci build workflow.
fixes: #181
Issue #, if available:
#181
Description of changes:
PR consists for two topics, first (and simplest) is to add Rocky Linux 9 to the circleci build workflow.
Second topic is that locally executed test with Rocky Linux 8 (
circleci local execute rocky8
) with circleci (version 0.1.29041+68d2c20) throws:followed by (because of missing source code):
Assumption why there is only a warning in https://app.circleci.com/pipelines/github/aws/efs-utils/237/workflows/574450d2-c225-4b9f-80f9-dfdcd153b530/jobs/4504/parallel-runs/0/steps/0-101: Older CircleCI version or if you run the tests online and not locally, seem to ship a build-in
git
binary as fallback, which cause a warning and recommendation to switch to a container image that includesgit
already.Best way to mitigate the warning and to fix the error seems to add
git
to the list of packages to be installed inside the container, ensure that/tmp/_circleci_local_build_repo
is recognized by git as safe directory (causeError: fatal: detected dubious ownership in repository
otherwise) and changing thebuild-rpm
steps that package install and safe directory command running beforecheckout
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Successfully tested with all builds that rely on
build-rpm-package
: