-
Notifications
You must be signed in to change notification settings - Fork 521
[test][benchmark][sagemaker][tensorflow,mxnet] Fix log file names #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][benchmark][sagemaker][tensorflow,mxnet] Fix log file names #1098
Conversation
| pytest.skip("Skipping benchmark test on TF 1.x images.") | ||
|
|
||
| processor = "gpu" if "gpu" in image_uri else "cpu" | ||
| device_cuda_str = f"gpu-{get_cuda_version_from_tag(image_uri)}" if processor == "gpu" else "cpu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this
| device_cuda_str = f"gpu-{get_cuda_version_from_tag(image_uri)}" if processor == "gpu" else "cpu" | |
| device_cuda_str = f"{processor}-{get_cuda_version_from_tag(image_uri)}" if processor == "gpu" else processor |
jeet4320
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge after reverting changes which was made in config
| pytest.skip("Skipping benchmark test on TF 1.x images.") | ||
|
|
||
| processor = "gpu" if "gpu" in image_uri else "cpu" | ||
| device_cuda_str = f"{processor}-{get_cuda_version_from_tag(image_uri)}" if processor == "gpu" else "cpu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: else "cpu" should be else processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Adding this as well.
Issue #, if available:
PR Checklist
Benchmark Checklist
src/config/test_config.pyin my PR branch by settingENABLE_BENCHMARK_DEV_MODE = TrueReviewer Checklist
Description:
PR to fix bug on TF2 SM benchmark tests where tests fail when aggregating throughput results due to overlapping log file names.
Tests run:
DLC image/dockerfile:
Additional context:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.