chore(custom-resource): extend alias to app-level and domain-level for NLB #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huanjani
reviewed
Nov 23, 2021
| regex: new RegExp(`^([^\.]+\.)?${domainName}`), | ||
| domain: `${domainName}`, | ||
| }, | ||
| OtherDomainZone: {}, |
There was a problem hiding this comment.
I'm just curious about this domainType. How is it used?
There was a problem hiding this comment.
Good catch! This is not used. I should just delete it!
efekarakus
reviewed
Nov 24, 2021
| @@ -9,7 +9,8 @@ const DELAY_RECORD_SETS_CHANGE_IN_S = 30; | |||
| const ATTEMPTS_CERTIFICATE_VALIDATED = 19; | |||
| const DELAY_CERTIFICATE_VALIDATED_IN_S = 30; | |||
|
|
|||
| let acm, envRoute53, envHostedZoneID, appName, envName, serviceName, certificateDomain; | |||
| let acm, appRoute53, envRoute53, rootHostedZoneID, appHostedZoneID, envHostedZoneID; | |||
There was a problem hiding this comment.
what do you think of something like this? Does it make testing difficult?
const clients = {
app: {
route53: ( () => {
let client;
return () => {
if (client) { return client }
client = new AWS.Route53({ ...});
return client;
}
})()
},
acm: (() => { let client; ... })(),
}This way throughout the code we can do client.app.route53() or client.acm() everything is guaranteed to be a singleton and it removes all these global clients
There was a problem hiding this comment.
Good idea - updated!
| @@ -141,8 +145,9 @@ async function validateAliases(aliases, loadBalancerDNS) { | |||
| let promises = []; | |||
|
|
|||
| for (let alias of aliases) { | |||
| const promise = envRoute53.listResourceRecordSets({ | |||
| HostedZoneId: envHostedZoneID, | |||
| let r = await domainResources(alias); | |||
There was a problem hiding this comment.
Suggested change
| let r = await domainResources(alias); | |
| let {hostedZoneId, route53, domain} = await domainResources(alias); |
efekarakus
added
the
do-not-merge
efekarakus
approved these changes
Nov 24, 2021
| }; | ||
| } | ||
|
|
||
| let hostecZoneID = { |
There was a problem hiding this comment.
🤣
Suggested change
| let hostecZoneID = { | |
| let hostedZoneID = { |
Lou1415926
removed
the
do-not-merge
efekarakus
reviewed
Nov 24, 2021
| @@ -239,11 +239,13 @@ async function validateAliases(aliases, loadBalancerDNS) { | |||
| if (!recordSet || recordSet.length === 0) { | |||
| return; | |||
| } | |||
| if (recordSet[0].Name !== alias) { | |||
…exactly the alias (it could be a record >= alias otherwise)
Lou1415926
force-pushed
the
nlb/lambda-create-other-hz
branch
from
886d523
to
1ae696f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #3057 takes into consideration only the case where the aliases are environment-level (e.g.
a.env.app.domain.com); however, they could also be app-level (e.g.a.app.domain.com) or root-level (e.g.a.domain.com). This PR extends the cases considered as such.In addition, the PR adds lazy-loading into the script.
Previous PR: #3057
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.