Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after drop of support for Python < 3.7 #387

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Conversation

michael-k
Copy link
Contributor

Issue #, if available: Closes #255

Description of changes:

  • Remove compatibility code for Python < 3.7
  • Introduce python_requires and cleanup setup.py
  • Use new style classes and super() calls
  • Remove unused config for Travis CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michael-k michael-k requested a review from a team as a code owner April 4, 2023 09:19
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
],

python_requires=">=3.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I believe this makes the removal of older runtimes safe for users using py <37 as they will not get the new version, right?

Copy link
Contributor Author

@michael-k michael-k Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as long as they use a recent enough release of pip (v9.0 released 2016-11-02) and the environment that generates the package metadata uses setuptools v24.2.0 (released 2016-07-20) or later.

Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through the code and cleaning up! 🙂

@srprash srprash merged commit 150f0ea into aws:master Apr 17, 2023
@michael-k michael-k deleted the cleanup branch April 19, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate support for python 2.7 and 3.4 in the next major version
2 participants