Change missing context default behavior to log #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
approved these changes
Sep 21, 2022
| @@ -171,11 +171,6 @@ public void testGetTraceEntityOnEmptyThreadDoesNotThrowException() { | |||
| AWSXRay.getTraceEntity(); | |||
| } | |||
|
|
|||
| @Test(expected = SegmentNotFoundException.class) | |||
There was a problem hiding this comment.
Instead of removing this test, can we modify it to test that the SegmentNotFoundException is not being thrown anymore? Would be helpful in flagging a similar behavior change in the future.
There was a problem hiding this comment.
That is what 957 - 972 do.
| AWSXRay.endSegment(); | ||
| AWSXRayRecorder recorder = AWSXRayRecorderBuilder.standard() | ||
| .withSamplingStrategy(new NoSamplingStrategy()) | ||
| .withContextMissingStrategy(new RuntimeErrorContextMissingStrategy()) |
There was a problem hiding this comment.
Does context missing strategy also handles the AlreadyEmittedException?
There was a problem hiding this comment.
Yes. I noticed it changed the behavior of that exception as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change the default behavior for missing context to log instead of throw an exception.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.