Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

S3 Delete No/Yes button labels are backwards #81

Merged
merged 2 commits into from
Aug 25, 2017
Merged

S3 Delete No/Yes button labels are backwards #81

merged 2 commits into from
Aug 25, 2017

Conversation

mmunn1
Copy link

@mmunn1 mmunn1 commented Aug 24, 2017 •
edited
Loading

Fix for #80 S3 Delete No/Yes button labels are backwards

zhangzhx
zhangzhx suggested changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@zhangzhx zhangzhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change Window.OK != dialog.open() 7 lines after to dialog.open() != 1 instead? dialog.open() returns the index of the button pressed while Window.OK is 0 which maps to the No button.

@zhangzhx
Copy link
Contributor

Thanks for the contribution and I've commented a bit for your code.

@zhangzhx
Copy link
Contributor

Thanks for the contribution. This will be included in the next release.

@zhangzhx zhangzhx merged commit c54da2a into aws:master Aug 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhangzhx zhangzhx zhangzhx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmunn1 @zhangzhx