Skip to content

Fix a bug in WorkflowTest.java #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a bug in WorkflowTest.java #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/com/amazonaws/services/simpleworkflow/flow/junit/WorkflowTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.util.Map;
import java.util.Map.Entry;

import com.amazonaws.services.simpleworkflow.flow.DataConverter;
import com.amazonaws.services.simpleworkflow.flow.JsonDataConverter;
import com.amazonaws.services.simpleworkflow.flow.test.TestDecisionContext;
import com.amazonaws.services.simpleworkflow.flow.test.TestLambdaFunctionClient;
Expand All @@ -45,13 +46,20 @@ public class WorkflowTest extends WorkflowTestBase {

private Map<String, TestPOJOActivityImplementationWorker> workers = new HashMap<String, TestPOJOActivityImplementationWorker>();

private DataConverter dataConverter;

public WorkflowTest() {
this(new JsonDataConverter);
}

public WorkflowTest(DataConverter dataConverter) {
super(new TestDecisionContext(new TestPOJOActivityImplementationGenericActivityClient(),
new TestPOJOWorkflowImplementationGenericWorkflowClient(), new TestWorkflowClock(), new TestWorkflowContext(),
new TestLambdaFunctionClient()));
activityClient = (TestPOJOActivityImplementationGenericActivityClient) decisionContext.getActivityClient();
workflowClient = (TestPOJOWorkflowImplementationGenericWorkflowClient) decisionContext.getWorkflowClient();
lambdaFunctionClient = (TestLambdaFunctionClient) decisionContext.getLambdaFunctionClient();
this.dataConverter = dataConverter;
}

public void addActivitiesImplementation(Object activitiesImplementation) {
Expand Down Expand Up @@ -84,7 +92,7 @@ public void addWorkflowImplementationType(Class<?> workflowImplementationType) {

public void addWorkflowImplementationType(Class<?> workflowImplementationType, Object[] constructorArgs) {
try {
workflowClient.addWorkflowImplementationType(workflowImplementationType, new JsonDataConverter(), constructorArgs, null);
workflowClient.addWorkflowImplementationType(workflowImplementationType, dataConverter, constructorArgs, null);
}
catch (Exception e) {
throw new IllegalArgumentException("Invalid workflow type: " + workflowImplementationType, e);
Expand Down