Use current thread resource context instead of system one #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmarty
approved these changes
May 10, 2022
willtong1234
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
I agree that the system classloader is probably the wrong one to use here. I go back and forth on whether we should use the current class classloader or the current thread context classloader. Unfortunately no matter which decision we make, we will probably not satisfy all customers. I'm going to approve this for now since I think the current thread context classloader should be sufficient in most cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change will allow the Config to be able to load resources if they arent on the system classpath, for instance, on a war deployed file, where the classloader cant see the secretsmanager.properties file because its only on the app classpath and not on the system one.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.