Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #210

Merged
merged 3 commits into from
Aug 29, 2023
Merged

V2 #210

merged 3 commits into from
Aug 29, 2023

Conversation

simonmarty
Copy link
Contributor

Issue #, if available:

Description of changes: Provide a v2 version of the Secrets Manager JDBC Library. Version 2 uses the Secrets Manager Caching library v2 under the hood, which itself uses the AWS Secrets Manager client for Java v2. The major version upgrade be a drop-in replacement for customers. Version 1 and 2 will keep being maintained side-by-side.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simonmarty simonmarty added the enhancement New feature or request label Aug 24, 2023
@simonmarty simonmarty self-assigned this Aug 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch coverage: 27.27% and project coverage change: -47.53% ⚠️

Comparison is base (d25e52d) 74.05% compared to head (78b869f) 26.53%.

Additional details and impacted files
@@              Coverage Diff              @@
##                 v2     #210       +/-   ##
=============================================
- Coverage     74.05%   26.53%   -47.53%     
+ Complexity      117       41       -76     
=============================================
  Files            11       11               
  Lines           343      343               
  Branches         42       42               
=============================================
- Hits            254       91      -163     
- Misses           82      249      +167     
+ Partials          7        3        -4     
Files Changed Coverage Δ
...ws/secretsmanager/sql/AWSSecretsManagerDriver.java 0.00% <0.00%> (-79.80%) ⬇️
...anager/sql/AWSSecretsManagerMSSQLServerDriver.java 0.00% <0.00%> (-60.00%) ⬇️
...etsmanager/sql/AWSSecretsManagerMariaDBDriver.java 0.00% <0.00%> (-52.39%) ⬇️
...cretsmanager/sql/AWSSecretsManagerMySQLDriver.java 0.00% <0.00%> (-50.00%) ⬇️
...retsmanager/sql/AWSSecretsManagerOracleDriver.java 0.00% <0.00%> (-60.00%) ⬇️
...manager/sql/AWSSecretsManagerPostgreSQLDriver.java 0.00% <0.00%> (-61.54%) ⬇️
...tsmanager/sql/AWSSecretsManagerRedshiftDriver.java 0.00% <0.00%> (-60.00%) ⬇️
...java/com/amazonaws/secretsmanager/util/Config.java 94.28% <ø> (ø)
...tsmanager/util/JDBCSecretCacheBuilderProvider.java 94.11% <85.71%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonmarty
Copy link
Contributor Author

Code coverage is inaccurate (unchanged from v1), had to break it due to dependency issues. Will fix in a future PR.

@simonmarty simonmarty merged commit ff03483 into aws:v2 Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants