Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #938 #940

Merged
merged 2 commits into from
Oct 13, 2015
Merged

Fixes #938 #940

merged 2 commits into from
Oct 13, 2015

Conversation

acolchagoff
Copy link
Contributor

Fixes issue where a non https url is given https.

@acolchagoff
Copy link
Contributor Author

Looks like the regex in the test was broken by the addition of :80 to the end of the domain in the url, also it was kind of too permissive in that it would allow:
http://myabucketacom/ but not http://my.bucket.com:80/

@trevorrowe trevorrowe merged commit bea86b7 into aws:master Oct 13, 2015
@trevorrowe
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolchagoff @trevorrowe