Accept #to_str attributes as Strings in dynamodb #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike #to_s, #to_str is only implemented by classes that act like strings. This change allows user-defined classes which provide that conversion to be used directly by dynamodb clients and be treated as String attributes. For example, users may define a class which is a composite of two or more values which are stored as a single String in dynamodb, and pass instances of that class into dynamodb clients without need for explicit conversion.
trevorrowe
added a commit
that referenced
this pull request
Sep 29, 2015
Accept #to_str attributes as Strings in dynamodb
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike #to_s, #to_str is only implemented by classes that act like
strings. This change allows user-defined classes which provide that
conversion to be used directly by dynamodb clients and be treated as
String attributes.
For example, users may define a class which is a composite of two or
more values which are stored as a single String in dynamodb, and pass
instances of that class into dynamodb clients without need for explicit
conversion.