Fix storage class setting on PresignedPost #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously storage_class would be passed as a vanilla form field which would be ignored by S3. The field should be passed as an "x-amz-storage-class" which requires a minimal change in the class descriptor. Once the field is set, the storage class is properly set on the POSTed object.
trevorrowe
added a commit
that referenced
this pull request
Sep 17, 2015
Fix storage class setting on PresignedPost
|
Thanks for the fix. This should go with the next release, possibly today. |
|
❤️ my pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously storage_class would be passed as a vanilla form field
which would be ignored by S3. The field should be passed as an
"x-amz-storage-class" which requires a minimal change in the
class descriptor. Once the field is set, the storage class is
properly set on the POSTed object.