Fix Aws::PageableResponse to correctly answer respond_to? with methods different than #count.
#911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different than #count.
…ods - `respond_to?` was not being forwarded to ancestors and it was always retuning `false` except for #count.
trevorrowe
added a commit
that referenced
this pull request
Aug 24, 2015
…rable-forward-respond-to Fix Aws::PageableResponse to correctly answer `respond_to?` with methods different than #count.
|
Thank you for the well formed pull-request! |
|
Also, this should go out in tomorrows release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aws::PageableResponse::UnsafeEnumerableMethodsis not forwardingrespond_to?to its ancestors (usingsuper) and it's always retuningfalse(except for #count). It breaksSearhorse::Client::Response#respond_to?: