Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Read IO Objects in Attribute Value Marshal #832

Merged
merged 2 commits into from
Jun 3, 2015
Merged

Commits on Jun 2, 2015

  1. Don't Read IO Objects in Attribute Value Marshal

    Resolves Issue #831
    
    Running the following code exercised the problem, and now works with
    this change:
    
    ```
    dynamodb.put_item(
      table_name: "foo",
      item: {
        id: 1,
        contents: StringIO.new("bar")
      }
    )
    ```
    
    The issue appeared to be that #read was called twice on the StringIO or
    IO object, and the second call would fail as String#read does not
    exist.
    awood45 committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    b59e760 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2015

  1. Fix IO Handling in DynamoDB Sets

    The hash and array logic used the format method changed in the previous
    diff, so those worked correctly from the outset. Sets, however, had
    special logic which required a second change.
    awood45 committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    2e23d35 View commit details
    Browse the repository at this point in the history