Simple type fixes and method change #820
Conversation
1. aws.rb
Instead of !array.include?() we can use exclude more readable. Benchmarked these methods. The result is same almost.
2. customizer.rb
Since shape_name is not used we can use each_value.
3. parse.rb
This can be initialized to empty array and hash. Does setting nil in method call make some memory manipulation.
Rest all files are simple typo fixes.
|
I responded with a pull request to your fork here: alkesh26#1 - This addresses the parser errors. The root cause is that a If you merge those changes, I'll be happy to these these. |
|
@trevorrowe I am very thankful for your response. Can you please help me more in understanding the error. May be with an example or some link. I am unable to identify the root cause. It will be of great help. And thanks a lot once again. Your comment made my day. :) |
|
Sure thing. When defining a Ruby method with a default value, that value is only used when the agument is not given. For example: def example(value = "default-value")
value
end
example
#=> "example-value"
example(nil)
#=> nilThe JSON parser was always passing the target parameter. This prevented the default values of |
Simple type fixes and method change
|
Thanks for the contribution! |
aws.rb
Instead of !array.include?() we can use exclude more readable. Benchmarked these methods. The result is same almost.
customizer.rb
Since shape_name is not used we can use each_value.
parse.rb
This can be initialised to empty array and hash.
Rest all files are simple typo fixes.