Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol tests with new changes to CBOR and Rest #3123

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Oct 9, 2024

Also a refactor of Cbor engine into the RpcV2 namespace

Copy link

github-actions bot commented Oct 9, 2024

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

github-actions bot commented Oct 9, 2024

Detected 17 possible performance regressions:

  • aws-sdk-cloudwatchlogs.client_init_ms - z-score regression: 0.71 -> 1.46. Z-score: 16.1
  • aws-sdk-cloudwatchlogs.put_log_events_small_ms - z-score regression: 0.46 -> 0.61. Z-score: 21.38
  • aws-sdk-cloudwatchlogs.get_log_events_small_ms - z-score regression: 0.34 -> 0.48. Z-score: 29.94
  • aws-sdk-cloudwatch.client_init_ms - z-score regression: 0.68 -> 1.19. Z-score: 21.47
  • aws-sdk-cloudwatch.put_metric_data_small_ms - z-score regression: 0.47 -> 1.07. Z-score: 57.53
  • aws-sdk-sns.client_init_ms - z-score regression: 0.65 -> 1.13. Z-score: 22.37
  • aws-sdk-sns.publish_small_ms - z-score regression: 0.45 -> 0.84. Z-score: 33.32
  • aws-sdk-sns.publish_large_ms - z-score regression: 2.82 -> 4.38. Z-score: 19.04
  • aws-sdk-s3.client_init_ms - z-score regression: 0.91 -> 1.75. Z-score: 31.71
  • aws-sdk-s3.get_object_small_ms - z-score regression: 0.45 -> 0.73. Z-score: 21.06
  • aws-sdk-s3.put_object_small_ms - z-score regression: 0.6 -> 1.58. Z-score: 61.19
  • aws-sdk-s3.head_object_ms - z-score regression: 0.79 -> 2.04. Z-score: 67.73
  • aws-sdk-dynamodb.client_init_ms - z-score regression: 0.7 -> 1.31. Z-score: 27.63
  • aws-sdk-dynamodb.put_item_small_ms - z-score regression: 0.58 -> 1.18. Z-score: 36.15
  • aws-sdk-kinesis.client_init_ms - z-score regression: 0.69 -> 1.36. Z-score: 19.22
  • aws-sdk-kinesis.put_record_small_ms - z-score regression: 0.37 -> 0.6. Z-score: 20.96
  • aws-sdk-kinesis.put_record_large_ms - z-score regression: 0.5 -> 1.37. Z-score: 53.2

@mullermp mullermp changed the title Always add accept header for cbor protocol Fix protocol tests with new changes to CBOR and Rest Oct 18, 2024
@mullermp mullermp merged commit d555e5a into version-3 Oct 18, 2024
31 checks passed
@mullermp mullermp deleted the cbor-accept branch October 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants