Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn using process credentials in shared config #3062

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Jul 3, 2024

Closes #3061

Shared config values are strings only. Strings will always warn for Process Credentials. So any time Process Credentials come from shared config, wrap it in an array.

@aws aws deleted a comment from github-actions bot Jul 3, 2024
Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mullermp mullermp merged commit 6f4c71d into version-3 Jul 3, 2024
28 checks passed
@mullermp mullermp deleted the fix-process-credentials-warning branch July 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants