-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protocol tests #2988
Update protocol tests #2988
Conversation
…ols" This reverts commit cecba46.
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
Current total of failures: 252 |
Current status: 197 failures, 50 ignored |
build_tools/aws-sdk-code-generator/spec/protocol-tests-ignore-list.json
Outdated
Show resolved
Hide resolved
Current status: 160 failures, 51 ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think we need to verify presigned urls, error cases, and general backwards compatibility. The content-type should not be blocked (see comment below).
I think that after those are confirmed and fixed, any other tests that are skipped can be done as follow ups? That makes review a bit easier too.
build_tools/aws-sdk-code-generator/spec/protocol_tests_spec_helper.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! These look good to me
Objectives
Starting total of failures: 349
Current total of failures: 0 but 2 ignored due to compatibility
Current standing:
We have 58 ignored testsWe just have 1 ignore test that we need to keep due to limitations on the JSON Engine11 tests cases rely on Smithy fixing the C2J translation (may require additional work after)4 test cases cannot be fixed due complex issue43 test cases to be resolved when test runner is updated to handle error cases (need to implement)There are 6 failures in our gem specs after making changes (these need to be investigated and resolve)There are 44 failures in the on build_tools directory (need to investigate and resolve)Clean up code (optimize approaches, etc)Create a comprehensive log of changes (intended for changelog)Create a list of services to manually test certain operations that are affected by some SDK core changesrun integration testsMANUAL TESTING IN PROGRESSBring over "extra" test cases (aka eventstreams) and update the formattingUpdate api-gateway protocol-tests formatting if neededCR review and update based on feedbackBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.md
file (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeature
orIssue
in the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!