Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for progress_callback in Object#download_file #2902

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Aug 18, 2023

Implements #2901
Closes #2681

This adds support for a progress_callback option in Object#download_file, similar to what is supported in upload_file.

This also improves the performance of download_file when multiple threads are used - previously it was done in batches, requiring all threads in the batch to complete before moving onto another batch (and additionally, creating a new set of threads each time instead of re-using one set of worker threads). This follows the approach used in the MultipartUploader.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@alextwoods alextwoods marked this pull request as ready for review August 21, 2023 21:30
@alextwoods alextwoods merged commit 8e6aac3 into version-3 Aug 22, 2023
27 checks passed
@mullermp mullermp deleted the file_download_progress branch August 22, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation for some S3 Object methods
2 participants