Fix Sign to not sign sigv2 cases #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in #2802
Custom endpoints will still flow through endpoint resolution, but for S3, it also returns Sigv4 signing. That endpoint is merged with service defaults (also Sigv4) and then eventually signed by the generic signer. Legacy sigv2 signing, when enabled, would sign on top of generic signing, which overrode Authorization. This worked for S3 but not for 3rd party solutions coincidentally because of Date Time parsing. This change fixes the behavior so that they are mutually exclusive.