Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance regression when checking if aws-crt is available. #2730

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Fix performance regression when checking if aws-crt is available. #2730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36269bc
Fix performance regression when checking if `aws-crt` is available.
alextwoods Jul 18, 2022
ae19c2c
Move setting of @@use_crt to class definition time
alextwoods Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gems/aws-sigv4/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Unreleased Changes
------------------

* Issue - Fix performance regression when checking if `aws-crt` is available. (#2729)

1.5.0 (2022-04-20)
------------------

Expand Down
16 changes: 10 additions & 6 deletions gems/aws-sigv4/lib/aws-sigv4/signer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ module Sigv4
#
class Signer

@@use_crt = nil

# @overload initialize(service:, region:, access_key_id:, secret_access_key:, session_token:nil, **options)
# @param [String] :service The service signing name, e.g. 's3'.
# @param [String] :region The region name, e.g. 'us-east-1'.
Expand Down Expand Up @@ -833,12 +835,14 @@ def crt_presign_url(options)
class << self

def use_crt?
begin
require 'aws-crt'
return true
rescue LoadError
return false
end
return @@use_crt unless @@use_crt.nil?
@@use_crt =
begin
require 'aws-crt'
true
rescue LoadError
false
end
end

# @api private
Expand Down