Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking AWS_REGION env as default region #2295

Closed
wants to merge 1 commit into from

Conversation

sivagollapalli
Copy link
Contributor

FIX #2112 issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/master/CONTRIBUTING.md

Thank you for your contribution!

@alextwoods
Copy link
Contributor

The SDK will already look for region (and other config values) in the ENV before other sources (See this dev guide for an overview of the order of preference or to see the code itself: CredentialProviderChain).

@mullermp mullermp closed this May 7, 2020
@mullermp
Copy link
Contributor

mullermp commented May 7, 2020

This doesn't fix the issue unfortunately. :( Thanks for opening the PR.

@sivagollapalli
Copy link
Contributor Author

@mullermp No problem. I will try to fix.

@alextwoods
Copy link
Contributor

@sivagollapalli - I don't think we should be changing the default behavior of Aws.config here (without a major version bump) as this could break current users. Aws.config is easy to update in application code, so users are not blocked from doing this themselves if its behavior they want.

@sivagollapalli
Copy link
Contributor Author

@alextwoods Would that mean are we discarding this issue #2112 or we are postponing till next major release?

@sivagollapalli sivagollapalli deleted the issue_2112 branch May 17, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: pre-populate Aws.config from environment
3 participants