Add whitelisting to headers for S3 presigning #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
commented
Aug 29, 2019
| 'referer', | ||
| 'te', | ||
| 'user-agent' | ||
| ].freeze |
There was a problem hiding this comment.
i removed 'x-amzn-trace-id' because the signer will add it for you:
@unsigned_headers << 'x-amzn-trace-id'
mullermp
commented
Aug 29, 2019
| @@ -361,7 +361,6 @@ def sign_event(prior_signature, payload, encoder) | |||
| # `:body_digest` in place of passing `:body`. | |||
| # | |||
| # @option options [Time] :time (Time.now) Time of the signature. | |||
| # You should only set this value for testing. | |||
There was a problem hiding this comment.
this wasn't true anymore!
mullermp
force-pushed
the
whitelist-headers-s3-presign
branch
from
b122e04
to
9fa7230
Compare
cjyclaire
approved these changes
Aug 29, 2019
cjyclaire
reviewed
Aug 29, 2019
| @@ -116,7 +109,22 @@ module S3 | |||
| time: Time.utc(1969, 4, 20) | |||
| } | |||
| actual_url = pre.presigned_url(:get_object, params) | |||
| expect(actual_url).to eq(expected_url) | |||
| expect(actual_url).to include(date_time) | |||
There was a problem hiding this comment.
Just a side note, not required, I'd prefer a more clear &X-Amz-Date=19690420T000000Z match or &X-Amz-SignedHeaders=host&user-agent,
mullermp
force-pushed
the
whitelist-headers-s3-presign
branch
from
9fa7230
to
396840f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
closes #2098