[Issue Fix] Make event emitter under module Aws #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awood45
suggested changes
May 22, 2018
There was a problem hiding this comment.
This is going to need any eventstream-dependent gems to lock on a minimum of the new aws-sdk-core version - otherwise, updating only a gem like aws-sdk-s3 could break. Now, if only core is updated, aws-sdk-s3 will break, but that's easier to fix. Let's add the new version lock before releasing.
|
Otherwise looks good, we can make a plan to release tomorrow. |
awood45
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1791
Tested locally that PR fixed the issue.
(With Integration test passing)