Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix ] remove raw_stream tracking #1787

Merged
merged 2 commits into from
May 18, 2018
Merged

[Bug Fix ] remove raw_stream tracking #1787

merged 2 commits into from
May 18, 2018

Conversation

cjyclaire
Copy link
Contributor

@cjyclaire cjyclaire commented May 18, 2018 •
edited
Loading

Address #1768

tested locally manually, integration tests passing

@cjyclaire cjyclaire requested a review from awood45 May 18, 2018 17:16
awood45
awood45 reviewed May 18, 2018
View reviewed changes
Copy link
Member

@awood45 awood45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify this change with a memory usage test, and further, does this change any of our test cases for event stream errors?

@cjyclaire cjyclaire merged commit fd7afb0 into master May 18, 2018
@awood45 awood45 mentioned this pull request May 18, 2018
Closed
@cjyclaire cjyclaire deleted the fix-raw-stream branch May 22, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awood45 awood45 awood45 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjyclaire @awood45