Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub Responses do not trigger response handlers #823

Closed
trevorrowe opened this issue May 22, 2015 · 1 comment
Closed

Stub Responses do not trigger response handlers #823

trevorrowe opened this issue May 22, 2015 · 1 comment

Comments

@trevorrowe
Copy link
Member

There have been multiple issues reported with response stubbing. While the feature works well in the normal case, it have a few notable issues.

The root cause is how the SDK attempts to simulate response stubs. It excersizes the entires HTTP request stack up to, but not including sending the request. This ensures the request is valid and can be marshaled. At this point is by-passes sending the HTTP request and directly returns a response with stubbed data.

The problem with this approach is that it does not exercise any of the response handlers and callbacks. This has caused the following issues:

The proposed fix is to generate actual HTTP responses from the stub data. This will allow the stub handler to trigger all of the HTTP events and exercise the full stack of handlers.

@trevorrowe
Copy link
Member Author

All known response stubbing issues have been resolved as of v2.1.0 which is now public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant