Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default :next_token to nil when using stub_responses #804

Closed
jkanywhere opened this issue May 2, 2015 · 1 comment
Closed

Change default :next_token to nil when using stub_responses #804

jkanywhere opened this issue May 2, 2015 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@jkanywhere
Copy link

Please change the default value of :next_token to nil when using stub_responses to provide a better default experience by avoiding apparent duplication of responses when using the Resource interface.

When I stub a describe_instances response to contain 1 ec2 instance, for example, it is confusing to get back two from Aws::Resource::EC2#instances.

Recommended by @trevorrowe
See jkanywhere/aws-ruby-sample@189dadf and aws-samples/aws-ruby-sample#3 for context.

If you point me at the correct class or file that handles this feature I am happy to try my hand at resolving this.
@trevorrowe trevorrowe added feature-request A feature should be added or improved. Version 2 labels May 15, 2015
@trevorrowe
Copy link
Member

I've added this to my backlog and this will hopefully be part of the 2.1 release.

@trevorrowe trevorrowe mentioned this issue May 22, 2015
Closed
@trevorrowe trevorrowe mentioned this issue Jun 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trevorrowe @jkanywhere