Ruby2.7 warns on Proc.new with no block (#2059)

* Ruby2.7 warns on Proc.new with no block
* sqs poller diff
* code-gen diff

build_tools/aws-sdk-code-generator/templates/event_streams_module.mustache

@@ -37,16 +37,16 @@ module {{module_name}}
 
       {{#types}}
       def on_{{.}}_event(&block)
-        @event_emitter.on(:{{.}}, Proc.new)
+        @event_emitter.on(:{{.}}, block) if block_given?
       end
 
       {{/types}}
       def on_error_event(&block)
-        @event_emitter.on(:error, Proc.new)
+        @event_emitter.on(:error, block) if block_given?
       end
 
       def on_initial_response_event(&block)
-        @event_emitter.on(:initial_response, Proc.new)
+        @event_emitter.on(:initial_response, block) if block_given?
       end
 
       def on_event(&block)

build_tools/aws-sdk-code-generator/templates/resource_class.mustache

@@ -97,10 +97,10 @@ module {{module_name}}
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [{{class_name}}]
-    def wait_until_{{name}}(options = {})
+    def wait_until_{{name}}(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::{{waiter_class_name}}.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       {{#wait_call}}
       {{#lines}}
       {{{.}}}{{/lines}}

gems/aws-sdk-autoscaling/lib/aws-sdk-autoscaling/auto_scaling_group.rb

@@ -229,10 +229,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [AutoScalingGroup]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::GroupExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(auto_scaling_group_names: [@name]))
       AutoScalingGroup.new({
         name: @name,
@@ -246,10 +246,10 @@ def wait_until_exists(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [AutoScalingGroup]
-    def wait_until_in_service(options = {})
+    def wait_until_in_service(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::GroupInService.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(auto_scaling_group_names: [@name]))
       AutoScalingGroup.new({
         name: @name,
@@ -263,10 +263,10 @@ def wait_until_in_service(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [AutoScalingGroup]
-    def wait_until_not_exists(options = {})
+    def wait_until_not_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::GroupNotExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(auto_scaling_group_names: [@name]))
       AutoScalingGroup.new({
         name: @name,

gems/aws-sdk-cloudformation/lib/aws-sdk-cloudformation/stack.rb

@@ -258,10 +258,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Stack]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::StackExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(stack_name: @name))
       Stack.new({
         name: @name,

gems/aws-sdk-cloudwatch/lib/aws-sdk-cloudwatch/alarm.rb

@@ -253,10 +253,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Alarm]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::AlarmExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(alarm_names: [@name]))
       Alarm.new({
         name: @name,

gems/aws-sdk-core/CHANGELOG.md

@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Issue - Mirgate Proc.new without a block usage #2058.
+
 3.54.1 (2019-05-30)
 ------------------
 

gems/aws-sdk-core/lib/aws-sdk-core/waiters/waiter.rb

@@ -50,7 +50,7 @@ def initialize(options = {})
       #
       # @yieldparam [Integer] attempts The number of attempts made.
       def before_attempt(&block)
-        @before_attempt << Proc.new
+        @before_attempt << block if block_given?
       end
 
       # Register a callback that is invoked after an attempt but before
@@ -81,7 +81,7 @@ def before_attempt(&block)
       # @yieldparam [Seahorse::Client::Response] response The response from
       #   the previous polling attempts.
       def before_wait(&block)
-        @before_wait << Proc.new
+        @before_wait << block if block_given?
       end
 
       # @option options [Client] :client

gems/aws-sdk-core/lib/seahorse/client/configuration.rb

@@ -104,7 +104,7 @@ def initialize
       #
       # @return [self]
       def add_option(name, default = nil, &block)
-        default = DynamicDefault.new(Proc.new) if block_given?
+        default = DynamicDefault.new(block) if block_given?
         @defaults[name.to_sym] << default
         self
       end

gems/aws-sdk-core/lib/seahorse/client/events.rb

@@ -9,7 +9,7 @@ def initialize(*args)
 
       def emit(event_name, *args, &block)
         @listeners[event_name] ||= []
-        @listeners[event_name] << Proc.new
+        @listeners[event_name] << block if block_given?
       end
 
       def signal(event, *args)

gems/aws-sdk-core/lib/seahorse/client/http/response.rb

@@ -122,15 +122,15 @@ def signal_error(networking_error)
         end
 
         def on_headers(status_code_range = nil, &block)
-          @listeners[:headers] << listener(status_code_range, Proc.new)
+          @listeners[:headers] << listener(status_code_range, block)
         end
 
         def on_data(&callback)
-          @listeners[:data] << Proc.new
+          @listeners[:data] << callback
         end
 
         def on_done(status_code_range = nil, &callback)
-          listener = listener(status_code_range, Proc.new)
+          listener = listener(status_code_range, callback)
           if @done
             listener.call
           else

gems/aws-sdk-core/lib/seahorse/client/plugin.rb

@@ -58,7 +58,7 @@ def option(name, default = nil, options = {}, &block)
           else
             options[:default] = default
           end
-          options[:default_block] = Proc.new if block_given?
+          options[:default_block] = block if block_given?
           self.options << PluginOption.new(name, options)
         end
 

gems/aws-sdk-ec2/lib/aws-sdk-ec2/image.rb

@@ -232,10 +232,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Image]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::ImageExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(image_ids: [@id]))
       Image.new({
         id: @id,

gems/aws-sdk-ec2/lib/aws-sdk-ec2/instance.rb

@@ -374,10 +374,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Instance]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::InstanceExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(instance_ids: [@id]))
       Instance.new({
         id: @id,
@@ -392,10 +392,10 @@ def wait_until_exists(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Instance]
-    def wait_until_running(options = {})
+    def wait_until_running(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::InstanceRunning.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(instance_ids: [@id]))
       Instance.new({
         id: @id,
@@ -410,10 +410,10 @@ def wait_until_running(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Instance]
-    def wait_until_stopped(options = {})
+    def wait_until_stopped(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::InstanceStopped.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(instance_ids: [@id]))
       Instance.new({
         id: @id,
@@ -428,10 +428,10 @@ def wait_until_stopped(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Instance]
-    def wait_until_terminated(options = {})
+    def wait_until_terminated(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::InstanceTerminated.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(instance_ids: [@id]))
       Instance.new({
         id: @id,

gems/aws-sdk-ec2/lib/aws-sdk-ec2/snapshot.rb

@@ -168,10 +168,10 @@ def data_loaded?
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Snapshot]
-    def wait_until_completed(options = {})
+    def wait_until_completed(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::SnapshotCompleted.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(snapshot_ids: [@id]))
       Snapshot.new({
         id: @id,

gems/aws-sdk-ec2/lib/aws-sdk-ec2/vpc.rb

@@ -141,10 +141,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Vpc]
-    def wait_until_available(options = {})
+    def wait_until_available(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::VpcAvailable.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(vpc_ids: [@id]))
       Vpc.new({
         id: @id,
@@ -158,10 +158,10 @@ def wait_until_available(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [Vpc]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::VpcExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(vpc_ids: [@id]))
       Vpc.new({
         id: @id,

gems/aws-sdk-ec2/lib/aws-sdk-ec2/vpc_peering_connection.rb

@@ -118,10 +118,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [VpcPeeringConnection]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::VpcPeeringConnectionExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       resp = waiter.wait(params.merge(vpc_peering_connection_ids: [@id]))
       VpcPeeringConnection.new({
         id: @id,

gems/aws-sdk-iam/lib/aws-sdk-iam/instance_profile.rb

@@ -127,10 +127,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [InstanceProfile]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::InstanceProfileExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(instance_profile_name: @name))
       InstanceProfile.new({
         name: @name,

gems/aws-sdk-iam/lib/aws-sdk-iam/user.rb

@@ -187,10 +187,10 @@ def exists?(options = {})
     # @option options [Proc] :before_attempt
     # @option options [Proc] :before_wait
     # @return [User]
-    def wait_until_exists(options = {})
+    def wait_until_exists(options = {}, &block)
       options, params = separate_params_and_options(options)
       waiter = Waiters::UserExists.new(options)
-      yield_waiter_and_warn(waiter, &Proc.new) if block_given?
+      yield_waiter_and_warn(waiter, &block) if block_given?
       waiter.wait(params.merge(user_name: @name))
       User.new({
         name: @name,

gems/aws-sdk-kinesis/lib/aws-sdk-kinesis/event_streams.rb

@@ -14,51 +14,51 @@ def initialize
       end
 
       def on_subscribe_to_shard_event_event(&block)
-        @event_emitter.on(:subscribe_to_shard_event, Proc.new)
+        @event_emitter.on(:subscribe_to_shard_event, block) if block_given?
       end
 
       def on_resource_not_found_exception_event(&block)
-        @event_emitter.on(:resource_not_found_exception, Proc.new)
+        @event_emitter.on(:resource_not_found_exception, block) if block_given?
       end
 
       def on_resource_in_use_exception_event(&block)
-        @event_emitter.on(:resource_in_use_exception, Proc.new)
+        @event_emitter.on(:resource_in_use_exception, block) if block_given?
       end
 
       def on_kms_disabled_exception_event(&block)
-        @event_emitter.on(:kms_disabled_exception, Proc.new)
+        @event_emitter.on(:kms_disabled_exception, block) if block_given?
       end
 
       def on_kms_invalid_state_exception_event(&block)
-        @event_emitter.on(:kms_invalid_state_exception, Proc.new)
+        @event_emitter.on(:kms_invalid_state_exception, block) if block_given?
       end
 
       def on_kms_access_denied_exception_event(&block)
-        @event_emitter.on(:kms_access_denied_exception, Proc.new)
+        @event_emitter.on(:kms_access_denied_exception, block) if block_given?
       end
 
       def on_kms_not_found_exception_event(&block)
-        @event_emitter.on(:kms_not_found_exception, Proc.new)
+        @event_emitter.on(:kms_not_found_exception, block) if block_given?
       end
 
       def on_kms_opt_in_required_event(&block)
-        @event_emitter.on(:kms_opt_in_required, Proc.new)
+        @event_emitter.on(:kms_opt_in_required, block) if block_given?
       end
 
       def on_kms_throttling_exception_event(&block)
-        @event_emitter.on(:kms_throttling_exception, Proc.new)
+        @event_emitter.on(:kms_throttling_exception, block) if block_given?
       end
 
       def on_internal_failure_exception_event(&block)
-        @event_emitter.on(:internal_failure_exception, Proc.new)
+        @event_emitter.on(:internal_failure_exception, block) if block_given?
       end
 
       def on_error_event(&block)
-        @event_emitter.on(:error, Proc.new)
+        @event_emitter.on(:error, block) if block_given?
       end
 
       def on_initial_response_event(&block)
-        @event_emitter.on(:initial_response, Proc.new)
+        @event_emitter.on(:initial_response, block) if block_given?
       end
 
       def on_event(&block)