Skip to content

Commit

Permalink
Revert "Prepare for Ruby 3.4 release - add dependencies on previously…
Browse files Browse the repository at this point in the history
… default gems (base64/bigdecimal) (#2986)"

This reverts commit 21f8d23.
  • Loading branch information
alextwoods committed Feb 12, 2024
1 parent 21f8d23 commit 96ad359
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,7 @@ def deprecated?
@service.deprecated?
end

Dependency = Struct.new(:gem, :version) do
def gem_version
[gem, version].compact.map { |s| "'#{s}'"}.join(', ')
end
end
Dependency = Struct.new(:gem, :version)

end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Gem::Specification.new do |spec|

{{/metadata}}
{{#dependencies}}
spec.add_dependency({{{gem_version}}})
spec.add_dependency('{{gem}}', '{{&version}}')
{{/dependencies}}

spec.required_ruby_version = '>= 2.5'
Expand Down
2 changes: 0 additions & 2 deletions gems/aws-sdk-core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
Unreleased Changes
------------------

* Issue - Add base64 as dependency to prepare for Ruby 3.4 release (#2984).

3.191.1 (2024-02-07)
------------------

Expand Down
1 change: 0 additions & 1 deletion gems/aws-sdk-core/aws-sdk-core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ Gem::Specification.new do |spec|
spec.add_dependency('aws-partitions', '~> 1', '>= 1.651.0') # necessary for new endpoint resolution
spec.add_dependency('aws-sigv4', '~> 1.8') # necessary for s3 express auth
spec.add_dependency('aws-eventstream', '~> 1', '>= 1.3.0') # necessary for binary eventstream
spec.add_dependency('base64') # necessary for base64 encoding/decoding

spec.metadata = {
'source_code_uri' => 'https://github.com/aws/aws-sdk-ruby/tree/version-3/gems/aws-sdk-core',
Expand Down
23 changes: 13 additions & 10 deletions services.json
Original file line number Diff line number Diff line change
Expand Up @@ -365,19 +365,13 @@
"Aws::DynamoDB::Plugins::ExtendedRetries",
"Aws::DynamoDB::Plugins::SimpleAttributes",
"Aws::DynamoDB::Plugins::CRC32Validation"
],
"dependencies": {
"bigdecimal": null
}
]
},
"DynamoDBStreams": {
"models": "streams.dynamodb/2012-08-10",
"addPlugins": [
"Aws::DynamoDBStreams::Plugins::SimpleAttributes"
],
"dependencies": {
"bigdecimal": null
}
]
},
"EBS": {
"models": "ebs/2019-11-02"
Expand All @@ -387,7 +381,10 @@
"addPlugins": [
"Aws::EC2::Plugins::CopyEncryptedSnapshot",
"Aws::EC2::Plugins::RegionValidation"
]
],
"dependencies": {
"aws-sigv4": "~> 1.0"
}
},
"EC2InstanceConnect": {
"models": "ec2-instance-connect/2018-04-02"
Expand Down Expand Up @@ -927,7 +924,10 @@
"models": "rds/2014-10-31",
"addPlugins": [
"Aws::RDS::Plugins::CrossRegionCopying"
]
],
"dependencies": {
"aws-sigv4": "~> 1.0"
}
},
"RDSDataService": {
"models": "rds-data/2018-08-01"
Expand Down Expand Up @@ -1019,6 +1019,9 @@
},
"S3Control": {
"models": "s3control/2018-08-20",
"dependencies": {
"aws-sigv4": "~> 1.1"
},
"addPlugins": [
"Aws::S3Control::Plugins::ARN",
"Aws::S3Control::Plugins::Dualstack",
Expand Down

0 comments on commit 96ad359

Please sign in to comment.