Skip to content

Commit

Permalink
Fix Travis + misc cleanup (#2389)
Browse files Browse the repository at this point in the history
  • Loading branch information
mullermp committed Aug 14, 2020
1 parent 38cc01d commit 969e16d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
13 changes: 4 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ rvm:
- 2.3
- 2.4
- 2.5
- 2.6
- 2.7
- jruby-9.1
- jruby-9.2

Expand All @@ -23,7 +25,8 @@ env:
- PURE_RUBY=1
- KITCHEN_SINK=1

script: bundle exec rake
# Disable Ruby warnings (Struct::Tms deprecation for 2.6+)
script: RUBYOPT='-W0' bundle exec rake

bundler_args: --without docs release repl

Expand All @@ -38,11 +41,3 @@ matrix:
env: OLD_OJ=1
- rvm: 2.3
env: OLD_OX=1

notifications:
webhooks:
urls:
- "https://webhooks.gitter.im/e/4442efd380ec811746d9"
on_success: change
on_failure: always
on_start: false
8 changes: 4 additions & 4 deletions UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
credential provider chain, and for default region selection. Since these
changes could technically be a breaking change to default (and commonly used)
behavior, there is a feature flag around this functionality.

To use these new features, you must set the `AWS_SDK_LOAD_CONFIG` environment
variable. If not set, the existing default behavior will continue.

Two other upgrading notes are worth keeping in mind for this release:

* Private interfaces regarding handling of configuration were changed for this
feature. Those interfaces were marked `@api private`, signifying that they
should not have been used outside the SDK for development. If you were
Expand Down Expand Up @@ -424,4 +424,4 @@ changes before 2.0.0 final.

# Upgrading from v1?

Please see [MIGRATING.md](https://github.com/aws/aws-sdk-ruby/blob/master/MIGRATING.md)
Please see [MIGRATING.md](https://github.com/aws/aws-sdk-ruby/blob/version-2/MIGRATING.md)
2 changes: 1 addition & 1 deletion aws-sdk-core/spec/aws/polly/presigner_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ module Polly
"us-west-2%2Fpolly%2Faws4_request&"\
"X-Amz-Date=20160101T112233Z&X-Amz-Expires=900&"\
"X-Amz-SignedHeaders=host&"\
"X-Amz-Signature=956ef486286b12f43ffc02dd09eae03cfea4cd8dfb30e0fab3f23de4e131195a"
"X-Amz-Signature=acb554087d5e340223b3415c79618adeb5c2b6dba19ba91771fbbe1d50a78f3d"

pre = Presigner.new(region: region, credentials: credentials)
params = {
Expand Down

0 comments on commit 969e16d

Please sign in to comment.