Resolved an issue with SQS queue poller and visibility timeouts.

Fixes #821
aws · May 19, 2015 · 3ae9fa4 · 3ae9fa4
1 parent 79fe570
commit 3ae9fa4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 Unreleased Changes
 ------------------
 
+* Issue - Aws:SQS - Resolved an issue with the SQS queue poller and changing message
+  visibility timeouts.
+
+  See [related GitHub issue #821](https://github.com/aws/aws-sdk-ruby/pull/821)
+
 2.0.44 (2015-05-18)
 ------------------
 

diff --git a/aws-sdk-resources/lib/aws-sdk-resources/services/sqs/queue_poller.rb b/aws-sdk-resources/lib/aws-sdk-resources/services/sqs/queue_poller.rb
@@ -346,7 +346,7 @@ def poll(options = {}, &block)
       #   `#receipt_handle`.
       # @param [Integer] seconds
       def change_message_visibility_timeout(message, seconds)
-        @client.change_message_visibility_timeout({
+        @client.change_message_visibility({
           queue_url: @queue_url,
           receipt_handle: message.receipt_handle,
           visibility_timeout: seconds,

diff --git a/aws-sdk-resources/spec/services/sqs/queue_poller_spec.rb b/aws-sdk-resources/spec/services/sqs/queue_poller_spec.rb
@@ -205,18 +205,20 @@ module SQS
         describe 'visibility timeouts' do
 
           it 'provides a method to update the visibility timeout of a message' do
-            expect(client).to receive(:change_message_visibility_timeout).with({
-              queue_url: queue_url,
-              receipt_handle: 'rh1',
-              visibility_timeout: 60,
-            })
             client.stub_responses(:receive_message, [
               { messages: [{ receipt_handle: 'rh1' }] },
               { messages: [] },
             ])
+            resp = nil
             poller.poll(idle_timeout:0) do |msg|
-              poller.change_message_visibility_timeout(msg, 60)
+              resp = poller.change_message_visibility_timeout(msg, 60)
             end
+            expect(resp.context.operation_name.to_s).to eq('change_message_visibility')
+            expect(resp.context.params).to eq({
+              queue_url: queue_url,
+              receipt_handle: 'rh1',
+              visibility_timeout: 60,
+            })
           end
 
         end