[V4] Remove redundant tests from .NET Standard project #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscpinheiro
commented
Dec 9, 2025
|
|
||
| [Fact] | ||
| [Trait(CategoryAttribute, "SQS")] | ||
| public async Task ListQueues() |
Contributor
Author
There was a problem hiding this comment.
This test was originally in sdk/test/NetStandard/IntegrationTests/SQSTests.cs
dscpinheiro
commented
Dec 9, 2025
| { | ||
| var listResponse = await Client.ListTopicsAsync(listRequest); | ||
| allTopics.AddRange(listResponse.Topics); | ||
| if (listResponse.Topics != null) |
Contributor
Author
There was a problem hiding this comment.
This test failed on one of my accounts where I didn't have any topics.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant integration test files from the .NET Standard project for AWS services that do not have hand-written code. This is a follow-up to a previous cleanup effort to eliminate duplicate test coverage.
Key Changes
- Removal of duplicate test files for multiple AWS services
- Consolidation of SQS tests into a single location
- Addition of null safety check in SNS integration tests
- Minor cleanup in ProtocolTests file
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/test/NetStandard/IntegrationTests/SQSTests.cs | Complete removal of duplicate SQS test file |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SimpleSystemsManagement.cs | Removal of SSM integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SimpleEmail.cs | Removal of SES integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SecurityToken/GetSessionToken.cs | Removal of STS GetSessionToken tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SecurityToken/GetFederationToken.cs | Removal of STS GetFederationToken tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SecurityToken/AssumeRoleWithWebIdentityCredentialsTests.cs | Removal of web identity credentials tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SQS.cs | Addition of ListQueues test and removal of unused helper methods |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/SNS.cs | Addition of null check before AddRange operation |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/Route53Domains.cs | Removal of Route53 Domains integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/RDS/BasicDescribes.cs | Removal of RDS BasicDescribes tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/ProtocolTests.cs | Removal of unused test methods and imports |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/MediaStoreData.cs | Complete removal of MediaStoreData integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/Kinesis.cs | Removal of Kinesis integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/IAM/Util.cs | Removal of IAM utility classes |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/IAM/AccessKeyTests.cs | Removal of IAM AccessKey tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/ECS.cs | Removal of ECS integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/DirectoryService.cs | Removal of Directory Service integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/DataPipeline.cs | Removal of Data Pipeline integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/CredentialsTests.cs | Removal of credentials integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/CodeDeploy.cs | Removal of CodeDeploy integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/CloudWatchLogs.cs | Removal of CloudWatch Logs integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/CloudHSM.cs | Removal of CloudHSM integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/CloudFront.cs | Removal of CloudFront integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/CloudFormation.cs | Removal of CloudFormation integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/Beanstalk.cs | Removal of Elastic Beanstalk integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/AutoScaling.cs | Removal of AutoScaling integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/ApplicationAutoscaling.cs | Removal of Application AutoScaling integration tests |
| sdk/test/NetStandard/IntegrationTests/IntegrationTests/AWSSupport.cs | Removal of AWS Support integration tests |
normj
approved these changes
Dec 9, 2025
ashishdhingra
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #4177, this PR removes the redundant tests from the .NET Standard project (i.e. services without hand-written code).
Testing
DRY_RUN-be48d17e-c726-47a2-b955-20195c4453d8License