Skip to content

Generate UpdateBucketMetadataTableConfiguration #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterrsongg wants to merge 1 commit into
base: peterrsongg/petesong/phase-3-pr5-rebased-2/2
Choose a base branch
from
+506 −367
Open

Generate UpdateBucketMetadataTableConfiguration #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion generator/ServiceClientGeneratorLib/ServiceModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,8 @@ public List<Operation> S3AllowListOperations
new Operation(this, "CreateBucketMetadataConfiguration",DocumentRoot[OperationsKey]["CreateBucketMetadataConfiguration"]),
new Operation(this, "GetBucketMetadataConfiguration", DocumentRoot[OperationsKey]["GetBucketMetadataConfiguration"]),
new Operation(this, "DeleteBucketMetadataConfiguration", DocumentRoot[OperationsKey]["DeleteBucketMetadataConfiguration"]),
new Operation(this, "ListObjects", DocumentRoot[OperationsKey]["ListObjects"])
new Operation(this, "ListObjects", DocumentRoot[OperationsKey]["ListObjects"]),
new Operation(this,"UpdateBucketMetadataJournalTableConfiguration", DocumentRoot[OperationsKey]["UpdateBucketMetadataJournalTableConfiguration"])
Comment on lines +579 to +580
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a required dev config file. According to CONTRIBUTING.md, all pull requests that modify code MUST include a DevConfig file in generator/.DevConfigs/ directory. This is essential for the release process and changelog generation.

For this change, you should create a dev config with a "major" type (breaking change) since the AssemblyComparer output shows removed methods (ConfigurationState, EncryptionConfiguration) and the operation signature has changed. Example structure:

{
  "services": [
    {
      "serviceName": "S3",
      "type": "major",
      "changeLogMessages": [
        "**Breaking Change** Fixed UpdateBucketMetadataJournalTableConfiguration operation to use correct API shape. Previous implementation used incorrect properties and did not work. Update code to use RecordExpiration property instead of ConfigurationState and EncryptionConfiguration."
      ],
      "backwardIncompatibilitiesToIgnore": [
        "Amazon.S3.Model.JournalTableConfigurationUpdates/MethodRemoved"
      ]
    }
  ]
}

See https://github.com/aws/aws-sdk-net/blob/main/CONTRIBUTING.md for details.

Copilot generated this review using guidance from repository custom instructions.
};
}
return _s3AllowListOperations.Where(operation => operation.data != null).ToList();
Expand Down
11 changes: 11 additions & 0 deletions generator/ServiceModels/s3/s3.customizations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,6 +1255,17 @@
"EncodingType":{"emitPropertyName":"Encoding"}
}
]
},
"UpdateBucketMetadataJournalTableConfigurationRequest":{
"modify":[
{
"ContentMD5":{"injectXmlIsSet":["return !String.IsNullOrEmpty(this._contentMD5);"]}
},
{
"ExpectedBucketOwner":{"injectXmlIsSet":["return !String.IsNullOrEmpty(this._expectedBucketOwner);"]}
}

]
}

},
Expand Down
128 changes: 0 additions & 128 deletions ...MarshallTransformations/UpdateBucketMetadataJournalTableConfigurationRequestMarshaller.cs
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions ...shallTransformations/UpdateBucketMetadataJournalTableConfigurationResponseUnmarshaller.cs
View file
Open in desktop

This file was deleted.

59 changes: 0 additions & 59 deletions sdk/src/Services/S3/Custom/Model/JournalTableConfigurationUpdates.cs
View file
Open in desktop

This file was deleted.

Loading