Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client-sso-oidc): move sts to peer #6224

Merged
merged 6 commits into from
Jun 26, 2024
Merged

chore(client-sso-oidc): move sts to peer #6224

merged 6 commits into from
Jun 26, 2024

Conversation

isaiahshall
Copy link
Contributor

Description

Modified codegen files to support moving the client-sts package to a peerDependency within the client-sso-oidc package. This is a fix for Turbo build errors due to cyclical dependencies.

Testing

  • Ran the generate-clients script & verified that the client-sso-oidc package.json reflects the intended changes.
  • Ran Turbo build to ensure that the packages now build successfully.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@isaiahshall isaiahshall marked this pull request as ready for review June 26, 2024 19:28
@isaiahshall isaiahshall requested a review from a team as a code owner June 26, 2024 19:28
@isaiahshall isaiahshall merged commit 1cc4de9 into aws:main Jun 26, 2024
5 checks passed
@isaiahshall isaiahshall deleted the fix-sts branch June 26, 2024 20:11
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants