Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): update smithy-typescript commit #5486

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Nov 13, 2023

Issue

Issue number, if available, prefixed with "#"

N/A.

Description

What does this implement/fix? Explain your changes.

Dependent on: smithy-lang/smithy-typescript#1068, smithy-lang/smithy-typescript#1073

Updates the smithy-typescript commit:

Testing

How was this change tested?

Codegen diff removes extraneous code section comments, e.g.

diff --git a/private/aws-echo-service/src/commands/EchoCommand.ts b/private/aws-echo-service/src/commands/EchoCommand.ts
index c98bd30baa4..1747a329b9d 100644
--- a/private/aws-echo-service/src/commands/EchoCommand.ts
+++ b/private/aws-echo-service/src/commands/EchoCommand.ts
@@ -67,16 +67,11 @@ export interface EchoCommandOutput extends EchoOutput, __MetadataBearer {}
  *
  */
 export class EchoCommand extends $Command<EchoCommandInput, EchoCommandOutput, EchoServiceClientResolvedConfig> {
-  // Start section: command_properties
-  // End section: command_properties
-
   /**
    * @public
    */
   constructor(readonly input: EchoCommandInput) {
-    // Start section: command_constructor
     super();
-    // End section: command_constructor
   }
 
   /**
@@ -126,7 +121,4 @@ export class EchoCommand extends $Command<EchoCommandInput, EchoCommandOutput, E
   private deserialize(output: __HttpResponse, context: __SerdeContext): Promise<EchoCommandOutput> {
     return de_EchoCommand(output, context);
   }
-
-  // Start section: command_body_extra
-  // End section: command_body_extra
 }

Additional context

Add any other context about the PR here.

Contains changes that will be used to enable experimentalIdentityAndAuth behavior.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall force-pushed the update-smithy-typescript-commit branch 2 times, most recently from a956361 to c8107d5 Compare November 14, 2023 00:12
@syall syall marked this pull request as ready for review November 14, 2023 00:46
@syall syall requested a review from a team as a code owner November 14, 2023 00:46
@syall syall force-pushed the update-smithy-typescript-commit branch 5 times, most recently from e88e7c8 to 3d4c847 Compare November 14, 2023 15:46
@syall syall force-pushed the update-smithy-typescript-commit branch from 3d4c847 to c32ab52 Compare November 14, 2023 16:17
@syall syall merged commit 6bd28f1 into aws:main Nov 14, 2023
2 checks passed
@syall syall deleted the update-smithy-typescript-commit branch November 14, 2023 17:22
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants