Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): downgrade typescript to ~4.3.5 #2782

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 13, 2021

Issue

Fixes: #2754

Description

Downgrade typescript to ~4.3.5, as named exports go missing when importing a CommonJS module compiled with Typescript 4.4 with importHelpers: true

Testing

Verified that ES6 import is successful by importing from workspace:

import { S3 } from "../aws-sdk-js-v3/clients/client-s3/dist/cjs/index.js";

Additional context

Issue reported with TypeScript upstream at microsoft/TypeScript#45813


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2782 (04cc39e) into main (ec03fa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2782   +/-   ##
=======================================
  Coverage   60.16%   60.16%           
=======================================
  Files         548      548           
  Lines       28585    28585           
  Branches     6997     6997           
=======================================
  Hits        17197    17197           
  Misses      11388    11388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec03fa0...04cc39e. Read the comment docs.

@trivikr trivikr merged commit 4e23736 into aws:main Sep 14, 2021
@trivikr trivikr deleted the downgrade-typescript branch September 14, 2021 20:18
trivikr added a commit to trivikr/temp-client-s3 that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonJS dist is imported instead of ESModule when using Node.js with ESModules, causing import errors.
3 participants