Skip to content

Use dynamic port for ApacheMetricsTest to reduce flakiness #6624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zoewangg merged 1 commit into from
Dec 15, 2025
Merged

Use dynamic port for ApacheMetricsTest to reduce flakiness #6624

zoewangg merged 1 commit into from
Dec 15, 2025

Conversation

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Dec 15, 2025

Use dynamic port for ApacheMetricsTest to reduce flakiness

Caused by: java.io.IOException: Failed to bind to /0.0.0.0:8080 
 at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:349) 
 at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:310) 
 at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80) 
 at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:234) 
 at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) 
 at org.eclipse.jetty.server.Server.doStart(Server.java:401) 
 at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) 
 at com.github.tomakehurst.wiremock.jetty9.JettyHttpServer.start(JettyHttpServer.java:218) 
 ... 36 more

@zoewangg zoewangg requested a review from a team as a code owner December 15, 2025 21:32
alextwoods
alextwoods approved these changes Dec 15, 2025
View reviewed changes
...lients/apache-client/src/test/java/software/amazon/awssdk/http/apache/ApacheMetricsTest.java

@Rule
public ExpectedException thrown = ExpectedException.none();
@RegisterExtension
Copy link
Contributor

@alextwoods alextwoods Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zoewangg zoewangg enabled auto-merge December 15, 2025 21:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 15, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zoewangg zoewangg added this pull request to the merge queue Dec 15, 2025
Merged via the queue into master with commit 7a1f13b Dec 15, 2025
39 of 40 checks passed
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alextwoods alextwoods alextwoods approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoewangg @alextwoods