-
Notifications
You must be signed in to change notification settings - Fork 972
Adding service endpoint section in config file #5944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RanVaknin
merged 9 commits into
master
from
rvaknin/add-services-section-in-ini-file-for-endpoint-url-support
Mar 18, 2025
Merged
Adding service endpoint section in config file #5944
RanVaknin
merged 9 commits into
master
from
rvaknin/add-services-section-in-ini-file-for-endpoint-url-support
Mar 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55413fd to
4a9a9ce
Compare
dagnir
reviewed
Mar 11, 2025
...ws-core/src/main/java/software/amazon/awssdk/awscore/endpoint/AwsClientEndpointProvider.java
Show resolved
Hide resolved
d471d58 to
b1084a2
Compare
dagnir
reviewed
Mar 12, 2025
...ws-core/src/main/java/software/amazon/awssdk/awscore/endpoint/AwsClientEndpointProvider.java
Show resolved
Hide resolved
Contributor
|
Can you kick off integ tests? |
Contributor
Author
Intg tests are passing for 5944. |
b1084a2 to
25c1495
Compare
millems
reviewed
Mar 14, 2025
...ws-core/src/main/java/software/amazon/awssdk/awscore/endpoint/AwsClientEndpointProvider.java
Outdated
Show resolved
Hide resolved
...ws-core/src/main/java/software/amazon/awssdk/awscore/endpoint/AwsClientEndpointProvider.java
Outdated
Show resolved
Hide resolved
...ted-classes-test/src/test/java/software/amazon/awssdk/services/EndpointSharedConfigTest.java
Outdated
Show resolved
Hide resolved
25c1495 to
71423c7
Compare
|
dagnir
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Motivation and Context
Support for service-specific endpoint overrides in the Java SDK was introduced in a #5562 , allowing services to resolve endpoints from environment variables and system properties.
However, service-specific overrides from
[services]section of the config file was not supported. Called out in #5779.This PR adds the functionality to provide an endpoint override through ~/.aws/config file's
[services]section.Example:
Modifications
servicesProperty()method inAwsClientEndpointProviderto extract and resolve service-specific endpoints from the [services] section.clientEndpointFromEnvironment()to use the newservicesPropertyin the correct load order.ProfileSectionenum to include a SERVICES section.Testing
EndpointSharedConfigTestto include [services] as a valid source for endpoint resolution.ProfileFileServicesTestclass to verify parsing and retrieval of service-specific endpoint settings.