-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Benchmark test for Checksums #5701
base: master
Are you sure you want to change the base?
Conversation
...dk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/checksum/CheckSumBenchmark.java
Outdated
Show resolved
Hide resolved
|
||
@Benchmark | ||
public void updateEntireByteArrayChecksum(ChecksumState state, Blackhole blackhole) { | ||
state.sdkChecksum.reset(); // Ensure we reset the checksum before each run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do reset in tearDown methond @TearDown
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
import software.amazon.awssdk.checksums.SdkChecksum; | ||
|
||
@State(Scope.Benchmark) | ||
@Warmup(iterations = 3, time = 3, timeUnit = TimeUnit.SECONDS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 3 seconds sufficient for warmup? Is the result consistent after warming up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test with both 3 and 15 , the relative Score is same .
However changed it to 15 to be consistent with other test
Quality Gate failedFailed conditions |
Motivation and Context
Modifications
Testing
updateEntireByteArrayChecksum (Java8)
updateIndividualByteChecksumOneByteATime (Java8)
updateEntireByteArrayChecksum (Java8)
updateIndividualByteChecksumOneByteATime (Java8)
License