Reuse connections for 5xx errors #5607
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zoewangg, I am working on an AWS SDK Http client based on pekko here, and the only failing test from Luckily I stumbled upon this PR, and I am just wondering why this functionality is being reverted? |
|
Hi @jtjeferreira, we are still evaluating the change. The main reason is that closing connections for 5xx errors could cause more TCP connection establishment in the unlikely event of outage, which could add request latency and add more load on the server side. In general, we try to keep custom logic in the SDK minimal and let the server side decide if a connection should be kept open or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Reuse connections for 5xx errors for all supported HTTP clients. This change reverts #1768 and #2960